fix: font selector does not work with recent puck canaries #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlife5
requested review from
mkilpatrick,
briantstephan,
colton-demetriou,
asanehisa and
jwartofsky-yext
asanehisa
approved these changes
Nov 21, 2024
mkilpatrick
changed the title
mkilpatrick
approved these changes
Nov 21, 2024
colton-demetriou
approved these changes
Nov 21, 2024
jwartofsky-yext
approved these changes
Nov 26, 2024
|
Planning to wait on merging until we actually go to upgrade puck versions so that we can test with the latest puck version |
|
Confirmed working with Puck 0.17.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upcoming puck fixes make the font selector re-mount more, so we need to use useCallback (like we do for the entire ThemeSidebar)
This works with our current puck version, but isn't needed until we upgrade again